Skip to content

Remove impl and api pattern in Nav3 #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jaehwa-Noh wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Remove impl and api pattern in Nav3 #2046

Jaehwa-Noh wants to merge 11 commits into from
+529 −907

Conversation

@Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Jan 20, 2026 •
edited
Loading

What I have done and why

This is what I addressed in #2009 (reply in thread)

This will lead easy to migrate Nav3 and implementation Nav3 just by creating navigation module.

No need split the feature modules to impl and api.

Jaehwa-Noh and others added 8 commits January 10, 2026 22:51
@Jaehwa-Noh
Hoist navigation click event to the app module and merge impl and api.
38a2044 
Change-Id: I0e69b45f89ca4236531efd82682345d0149a0424
@Jaehwa-Noh
Create :navigation module.
d82d219 
Change-Id: I0c3c5ced03d6d26fcdaaaa00f7df75682cec83dc
@Jaehwa-Noh
Set default test dependency at feature plugins.
6ac8d13 
Change-Id: Ie4cc71b900bb0760b94c3efcae707d31fbc09a91
@Jaehwa-Noh
Move extensions and navigation related things to navigation module.
44dbd93 
Change-Id: Icd75f90868dccb6b443e72765d4afc9a2ceb9778
@Jaehwa-Noh
Set dependency up.
3d3b968 
Change-Id: Ieb49d09db7400b10031e08dbac72e0ef5aa404a6
@Jaehwa-Noh
Merge Api and Impl module into one feature module.
4a90bda 
Change-Id: I72bf1bfdd86d1782cd25b84f8c85bccb0a16faf9
@Jaehwa-Noh
Update README.
b0ba79f 
Change-Id: Id0b58f086367f7d0e501d61146dab946a12370f2
@Jaehwa-Noh @github-actions
🤖 Updates screenshots
48cc33c
@Jaehwa-Noh Jaehwa-Noh requested a review from dturner as a code owner January 20, 2026 12:02
@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 20, 2026

Summary of Changes

Hello @Jaehwa-Noh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the application's module structure by eliminating the impl and api module pattern for features and introducing a new, centralized :navigation module. This change aims to simplify the project's architecture, making it easier to manage dependencies, integrate new navigation features, and improve overall maintainability by decoupling feature modules from their navigation implementation details.

Highlights

  • Module Structure Simplification: The impl and api suffixes have been removed from feature modules, consolidating them into single modules (e.g., feature:foryou:api and feature:foryou:impl are now feature:foryou). This simplifies the module graph and dependency management.
  • New Navigation Module: A new dedicated :navigation module has been introduced to centralize navigation-related logic, including entry providers, navigation utilities, and top-level navigation item definitions. This module now handles the integration of feature module navigation.
  • Build Configuration Updates: Gradle build files (build.gradle.kts) across the application, features, and build-logic have been updated to reflect the new module naming conventions and dependencies. The androidFeatureImpl and androidFeatureApi convention plugins were removed and replaced by a single androidFeature plugin.
  • Code Refactoring for Navigation: Application-level navigation logic in NiaApp.kt and NiaAppState.kt has been refactored to utilize the new :navigation module's utilities and extension functions, streamlining how navigation is handled and reducing direct dependencies on individual feature modules' internal navigation details.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 20, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant refactoring that removes the api and impl module separation for feature modules, introducing a new centralized navigation module. This simplifies the module structure and dependency graph. The changes are extensive, touching build scripts, documentation, and source code across many modules.

The refactoring has been carried out consistently across all feature modules. The new navigation module effectively centralizes navigation logic that was previously spread across feature api modules.

My review has identified a few minor issues: a typo in a function name, a misplaced composition local, and a typo in a README file. These are small fixes that will improve the overall quality of the codebase. Overall, this is a great improvement to the project's architecture.

Jaehwa-Noh and others added 3 commits January 20, 2026 21:18
@Jaehwa-Noh @gemini-code-assist
Update navigation/src/main/kotlin/com/google/samples/apps/nowinandroi…
3e0df84 
…d/navigation/Utils.kt


Fix typo

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Jaehwa-Noh @gemini-code-assist
Update feature/search/README.md
454d11e 
Fix typo.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Jaehwa-Noh
Fix typo.
da82920 
Change-Id: I64dc52976dcc4c32f34d0d8bb1cf7d0bc9438f31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dturner dturner Awaiting requested review from dturner dturner is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jaehwa-Noh